Skip to content

Udp network API (part 2) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2025
Merged

Udp network API (part 2) #14

merged 6 commits into from
Nov 14, 2025

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 14, 2025

Motivation

Added some changes to the UDP API.

Change description

  • Added new methods for writing packets in multiple passes.
  • Renamed awaitRead -> awaitPacket (for consistency).
  • Added dropPacket method.

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@cmaglie cmaglie self-assigned this Nov 14, 2025
@cmaglie cmaglie added the enhancement New feature or request label Nov 14, 2025
@cmaglie cmaglie mentioned this pull request Nov 14, 2025
Merged
eigen-value
eigen-value requested changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@eigen-value eigen-value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a small typo to correct

@cmaglie cmaglie merged commit d67f01e into main Nov 14, 2025
4 checks passed
@cmaglie cmaglie deleted the udp-net-part-2 branch November 14, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eigen-value eigen-value eigen-value approved these changes

Assignees

@cmaglie cmaglie

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie @eigen-value